experimental: Use shared memory pool even when offHeap is not enabled #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
============================================
+ Coverage 34.03% 34.20% +0.16%
- Complexity 875 883 +8
============================================
Files 112 112
Lines 43289 43442 +153
Branches 9572 9625 +53
============================================
+ Hits 14734 14859 +125
+ Misses 25521 25519 -2
- Partials 3034 3064 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #996
Rationale for this change
We currently create separate memory pools for each native plan within an executor and we do not take concurrency into account when executors have multiple cores assigned, making this difficult to configure.
What changes are included in this PR?
Always use a shared memory pool per executor.
How are these changes tested?